Skip to content

fix: add logging for start_session details#299

Merged
nrfulton merged 6 commits intogenerative-computing:mainfrom
psschwei:session-start-logging
Jan 16, 2026
Merged

fix: add logging for start_session details#299
nrfulton merged 6 commits intogenerative-computing:mainfrom
psschwei:session-start-logging

Conversation

@psschwei
Copy link
Member

@psschwei psschwei commented Jan 9, 2026

Fixes #39

Adds an info-level log message when start_session() is called, displaying the backend name, model ID (resolved for the specific backend), context type, and model options (if provided).

Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
@mergify
Copy link

mergify bot commented Jan 9, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|release)(?:\(.+\))?:

@nrfulton nrfulton self-requested a review January 13, 2026 17:03
@nrfulton nrfulton self-requested a review January 13, 2026 17:14
@nrfulton
Copy link
Member

Looks good, except for the failing ruff prec-commit hook.

Please run the pre-commit hooks and push ruff's changes. I'll then approve and merge.

Thanks for the contribution!

Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
@psschwei
Copy link
Member Author

Please run the pre-commit hooks and push ruff's changes

done!

@nrfulton
Copy link
Member

Thanks, looks good. We're in code freeze until #310 is merged. That should resolve automatically for this PR. I will merge this some time tomorrow, or ping you if there are unanticipated merge issues.

@nrfulton
Copy link
Member

nrfulton commented Jan 16, 2026

#310 is now merged. Updated this branch and re-ran workflows. Will merge on success. Thanks for the patience.

@nrfulton nrfulton merged commit 6e68f57 into generative-computing:main Jan 16, 2026
4 checks passed
@psschwei psschwei deleted the session-start-logging branch January 16, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add logging for start_session details

2 participants